Fixed minor bug in CPAN::Mini::Inject::inject() if verbose.#21
Fixed minor bug in CPAN::Mini::Inject::inject() if verbose.#21WolfgangPecho wants to merge 1 commit intoAndyA:masterfrom
Conversation
|
|
||
| # if verbose report target file and the modules it contains | ||
| if ( $verbose ) { | ||
| for my $target (keys %report) { |
There was a problem hiding this comment.
Maybe the keys should be sorted? That would make reading the report easier. Since we cannot have them in the order they were done, we can at least have them in some order, rather than random.
|
@wchristian I've reviewed this PR as part of my Pull Request Challenge entry for September 2017 and think it can be merged without problems. There's the one thing I think could be a bit more convenient, but that's trivial to add. Updating the documentation might make sense too.
could become something like
|
|
I've cherry-picked this into briandfoy/cpan-mini-inject@93b4e0d |
|
This is part of 1.002. I can't close this issue though. Thanks, |
3 participants
CPAN::Mini::Inject::inject() reports only the first module of a dist file if verbose is on. It should
report each injected Module for each dist file.
The line
prevented printing of other modules.